Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: stop setting ims org to state lib for dead validator #167

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

moritzraho
Copy link
Member

Description

fix for #166. This code can be safely deleted now, it was kept as a strategy to rollback to the headless-v1 validator in 2021 see #65

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #167 (8a1c2ee) into master (e881556) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1314      1300   -14     
  Branches       349       345    -4     
=========================================
- Hits          1314      1300   -14     
Files Coverage Δ
src/deploy-actions.js 100.00% <ø> (ø)
src/utils.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MichaelGoberling MichaelGoberling self-requested a review October 26, 2023 15:09
Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moritzraho moritzraho merged commit c05f4d2 into master Oct 26, 2023
@moritzraho moritzraho deleted the fix-ims-org-to-statelib branch October 26, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants