Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breaking-change): update for nodes 18 and 20 #170

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Nov 14, 2023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30c96f5) 100.00% compared to head (ab0360a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1300      1300           
  Branches       345       345           
=========================================
  Hits          1300      1300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelGoberling MichaelGoberling self-requested a review November 21, 2023 14:51
@shazron
Copy link
Member Author

shazron commented Dec 4, 2023

utils.test.js zip archiver tests are failing because of our fake file system (archiver doesn't like something in node >=18).

@shazron shazron merged commit 4c4d0ff into master Dec 12, 2023
@shazron shazron deleted the update-node-18-20 branch December 12, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants