Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-2738 - failing e2e tests because of mocked fs #173

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 16, 2024

How Has This Been Tested?

  • npm run e2e

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f54ebba) 100.00% compared to head (a471a5b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #173   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1300      1300           
  Branches       345       345           
=========================================
  Hits          1300      1300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron changed the title fix: failing e2e tests because of mocked fs fix: ACNA-2738 - failing e2e tests because of mocked fs Jan 16, 2024
@shazron shazron merged commit 73f3c37 into master Jan 17, 2024
7 checks passed
@shazron shazron deleted the fix=e2e-tests branch January 17, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e tests are failing
4 participants