Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACNA-1828 | Externalised the workflow #175

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

amulyakashyap09
Copy link
Contributor

Description

Linking the workflow to external file

Related Issue

ACNA-1828

Motivation and Context

It removes redundancy, centralises the workflow

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8caed7b) 100.00% compared to head (b8a5684) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1303      1303           
  Branches       346       346           
=========================================
  Hits          1303      1303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron
Copy link
Member

shazron commented Jan 26, 2024

@amulyakashyap09 Needs required checks change in Branch protection settings.

@amulyakashyap09 amulyakashyap09 merged commit 8fd983f into master Feb 12, 2024
7 checks passed
@amulyakashyap09 amulyakashyap09 deleted the feature/externalising-github-workflows branch February 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants