Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize deploy #193

Merged
merged 10 commits into from
Sep 25, 2024
Merged

Optimize deploy #193

merged 10 commits into from
Sep 25, 2024

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Aug 22, 2024

Description

These changes use 2 lists to determine if things have changed since last build/deploy

  • A build list is kept which records a hash of an action's src directory
  • A deploy list records what was deployed, including a hash of action descriptor so that even changes to action inputs, or .env values will force a re-deploy.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (759cb6d) to head (9ed2b2b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #193   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1309      1328   +19     
  Branches       349       350    +1     
=========================================
+ Hits          1309      1328   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purplecabbage purplecabbage marked this pull request as ready for review August 22, 2024 23:38
@purplecabbage purplecabbage requested a review from shazron August 22, 2024 23:38
src/build-actions.js Show resolved Hide resolved
src/deploy-actions.js Show resolved Hide resolved
src/deploy-actions.js Show resolved Hide resolved
src/deploy-actions.js Show resolved Hide resolved
@purplecabbage purplecabbage merged commit 7128745 into master Sep 25, 2024
8 checks passed
@purplecabbage purplecabbage deleted the opt-deploy branch September 25, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants