DEVSITE-592-inconsistent-image-size #1526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrymatio
reviewed
Jul 12, 2023
| @@ -114,6 +114,9 @@ const Tr = ({ children, ...props }) => { | |||
| ? children | |||
| : children.map((child, index) => { | |||
| child.props.cellWidth = columnWidthDistribution[index]; | |||
| if (child.props?.children?.props?.children?.props) { | |||
There was a problem hiding this comment.
Assuming this is for a specifically for the Image componenet:
Can this be more specific? child.props?.children?.props?.children?.props can flag potentially any child component props, and the isTable prop could cause unwanted changes in them.
If we want to set context across all children within table we should set context instead of prop drilling.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the inconsistent image width if it's within a table cell.
Description
Fix the inconsistent image width if it's within a table cell.
Related Issue
https://jira.corp.adobe.com/browse/DEVSITE-592
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: