Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a frontmatter reporting step to algolia indexing #1529

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

dmitrymatio
Copy link
Collaborator

@dmitrymatio dmitrymatio commented Jul 21, 2023

Description

Added a reporting step to pass/fail pages based on frontmatter completion.

Currently checking for title, description, keywords as they're the essential for search results.

Related Issue

Motivation and Context

How Has This Been Tested?

Tested example locally as part of the console only index run with no indices sent to algolia.

Screenshots (if appropriate):

Example of starting and fail messages
image

Example of pass message
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dmitrymatio dmitrymatio requested a review from timkim as a code owner July 21, 2023 22:12
@louisachu louisachu self-requested a review July 21, 2023 23:21
@dmitrymatio dmitrymatio merged commit 76853ce into main Jul 22, 2023
2 checks passed
@dmitrymatio dmitrymatio deleted the DEVSITE-461/add-frontmatter-reporter branch July 22, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants