Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore md pages when indexing if noIndex keyword set true #1535

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

dmitrymatio
Copy link
Collaborator

@dmitrymatio dmitrymatio commented Aug 24, 2023

Description

Added support for flagging a page as noIndex.
Search index operation will ignore pages with noIndex: true in frontmatter.
This is a simple feature but important for repos with transcluded pages under src/pages/ where we index all md pages by default. Currently such repos show duplicate results for the transcluded content in local search. The noIndex flag will help with removing these duplicates.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dmitrymatio dmitrymatio changed the title feat: support noIndex bool in frontmatter Ignore md pages when indexing if noIndex keyword set true Aug 24, 2023
@timkim timkim merged commit d7e6063 into main Aug 24, 2023
2 checks passed
@timkim timkim deleted the DEVSITE-685/search-shows-transcluded-files branch August 24, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants