Get credential phase 2 #1575

BaskarMitrah · 2024-05-08T15:49:23Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

packages/gatsby-theme-aio/src/components/GetCredential/CredentialForm.js

packages/gatsby-theme-aio/src/components/GetCredential/FormFields.js

packages/gatsby-theme-aio/src/components/GetCredential/Organization.js

packages/gatsby-theme-aio/src/components/GetCredential/PreviousCredential.js

packages/gatsby-theme-aio/src/components/GetCredential/Products.js

* feat: wired up get template by id and install template endpoints * fix: remove unused code * Delete yarn.lock --------- Co-authored-by: BaskarMitrah <113968869+BaskarMitrah@users.noreply.github.com>

This reverts commit 07751e0.

deepessh

Thank you so much @BaskarMitrah!

packages/gatsby-theme-aio/src/components/GetCredential/Card/AccessToken.js

packages/gatsby-theme-aio/src/components/GetCredential/FormFields.js

packages/gatsby-theme-aio/src/components/GetCredential/Return/ReturnProduct.js

* -- Removed the Subscription Error * renamed NestedAlertContent files * --Fixed Sample code download issues * --fixed the project link to the card after create the credential * --Fixed the checkmark issues on the picker in the return flow project details * Fixed scopes details as dynamic * --Separated the Service and formfields page --------- Co-authored-by: BaskarMitrah <mit44186@adobe.com> Co-authored-by: Manimaran Kottursamy <mit80447@adobe.com>

* Fix : Error in form details clears the form. Should not clear it. The toast message does not dismiss on it's own * --Added validation for the domain * --Fixed design issues * --Credential name validation

* --Fixed the issues on the generate token & client secret * fix : added copy icon for access token & client secret

… up automatically, I have to refresh the page or the request access button keeps showing. (#1596) If I fill out the form and change the org, the form fields reset. Only the dev terms acceptance should reset. Rest everything should stay the same. Co-authored-by: BaskarMitrah <mit44186@adobe.com>

fix: Personal Developer Org bug on org switcher and error states (#1598)

timkim · 2024-07-10T23:16:50Z

packages/gatsby-theme-aio/src/components/GetCredential/PreviousCredential.js

+import { PreviousProject } from './PreviousProject';
+import { Organization } from './Organization';
+import { CredentialForm } from './CredentialForm';
+import { RetunrSideComp } from './Return/RetunrSideComp';


timkim · 2024-07-10T23:20:56Z

package.json

- "packageManager": "yarn@3.2.3"
+ "packageManager": "yarn@3.2.3",
+ "dependencies": {
+ "@adobe/react-spectrum": "^3.35.0",


I'm not sure about including react-spectrum as a dependency. It looks like we are just using it for a few ui components. I would like to not have react-spectrum as it would increase the bloat/size of the theme for all who consume it. Moreover, most people who do use the theme won't be using the create credentials component.

I think moving forward we would want to remove whatever ui components we are getting from it and just create our own version of those ui components.

timkim

Only one change needed as noted by the typo I found.

build : Initial commit for get credential phase 2

552e964

BaskarMitrah requested a review from timkim May 8, 2024 15:49

BaskarMitrah marked this pull request as draft May 8, 2024 16:04

deepessh reviewed May 8, 2024

View reviewed changes

BaskarMitrah added 2 commits May 10, 2024 21:00

build : --Added the separated components and moved into folder

ba795ea

build : --Updated the get crdential external page

d135190

deepessh approved these changes May 13, 2024

View reviewed changes

deepessh and others added 11 commits May 15, 2024 20:14

feat: wired up get template by id and install template endpoints (#1577)

bf902ee

* feat: wired up get template by id and install template endpoints * fix: remove unused code * Delete yarn.lock --------- Co-authored-by: BaskarMitrah <113968869+BaskarMitrah@users.noreply.github.com>

fix: added request access

098278a

integrated request access

c5871a7

build : Fixed design issues & Removed unwanted code

07d5c60

fix: code improvements

aa23c65

build : fixed the design issues and removed the unwanted code

07751e0

Revert "build : fixed the design issues and removed the unwanted code"

bb416e8

This reverts commit 07751e0.

build:added some design issue (#1580)

de3ae10

fix: incorrect import

b5a6e12

build: update change organization

943d83b

fix: build issue

33e3d03

timkim approved these changes May 20, 2024

View reviewed changes

timkim marked this pull request as ready for review May 20, 2024 17:45

Add back in yarn.lock

452fc1c

timkim marked this pull request as draft May 20, 2024 17:47

timkim and others added 7 commits May 20, 2024 10:54

Increase cypress timeout

cf0b0b9

Increase cypress timeout again

60b42b9

added hardcoded wiring for generating access token

e0aaf36

build : showed access token and secret key in the card

0bf2dea

Added optional chaining to the response

e00d2ff

fix: oauths2s and api key get credential components

b06bfc8

--Fixed bugs

e22e257

deepessh reviewed May 23, 2024

View reviewed changes

deepessh and others added 19 commits June 6, 2024 15:28

fix: code improvements and bug fixes

96a6a68

Merge remote-tracking branch 'origin/main' into get_credential_phase2

3bcc5b5

removed unnecessary console.log

6f18f83

feat: use window.adobeIMS instead of ims from context

4922ec4

--Updated helptext (#1589)

57615e6

Error in form (#1590)

48cfb7b

* Fix : Error in form details clears the form. Should not clear it. The toast message does not dismiss on it's own * --Added validation for the domain * --Fixed design issues * --Credential name validation

--Added manage developer console as a optional (#1591)

7f5f109

--Fixed the issues on the generate token & client secret (#1592)

771bca4

* --Fixed the issues on the generate token & client secret * fix : added copy icon for access token & client secret

Fix : project name issues in the return flow (#1593)

396613d

fix : Updated role text in the organization (#1600)

3c5f846

Fix : Picker design issues (#1594)

508ebd6

fix: added email to request access (#1599)

579839e

fix: dropdown similarity (#1597)

f4cfeb5

fix: added loading text to the loader (#1595)

fe6416a

fix: Personal Developer Org bug on org switcher and error states (#1598)

a4415e9

fix: Personal Developer Org bug on org switcher and error states (#1598)

Merge remote-tracking branch 'origin/main' into get_credential_phase2

0d2f95b

chore: release rc version

c450505

deepessh marked this pull request as ready for review July 9, 2024 16:15

deepessh added 3 commits July 9, 2024 12:40

fix: issue with download, bump version

bd80871

chore: update version in package.json

c2efa3f

chore: updated changelog

faec892

timkim reviewed Jul 10, 2024

View reviewed changes

timkim requested changes Jul 10, 2024

View reviewed changes

deepessh added 2 commits July 10, 2024 16:27

fix: typo

ead5d5e

chore: update version in package.json and changelog

196a66d

timkim merged commit 2200844 into main Jul 10, 2024
3 checks passed

timkim deleted the get_credential_phase2 branch July 10, 2024 23:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get credential phase 2 #1575

Get credential phase 2 #1575

BaskarMitrah commented May 8, 2024

deepessh left a comment

timkim Jul 10, 2024

timkim Jul 10, 2024

timkim Jul 10, 2024

timkim left a comment

Get credential phase 2 #1575

Get credential phase 2 #1575

Conversation

BaskarMitrah commented May 8, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

deepessh left a comment

Choose a reason for hiding this comment

timkim Jul 10, 2024

Choose a reason for hiding this comment

timkim Jul 10, 2024

Choose a reason for hiding this comment

timkim Jul 10, 2024

Choose a reason for hiding this comment

timkim left a comment

Choose a reason for hiding this comment