Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devsite 466 hero component displays scrollbar #1582

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

Elisha-Edme
Copy link
Collaborator

Description

A vertical scroll bar appears when the window size is less than ~1200 pixels. This scroll bar is unaesthetic and must be fixed.

Related Issue

https://jira.corp.adobe.com/browse/DEVSITE-466

Motivation and Context

Having the scroll bar is unappealing and unnecessary for hero components.

How Has This Been Tested?

I used yarn dev to build the example page, and then I decreased the width of the screen until the scroll bar appeared. After modifying the CSS, the issue no longer appeared.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Elisha-Edme Elisha-Edme requested a review from timkim as a code owner June 5, 2024 17:29
@timkim timkim merged commit 2264f47 into main Jun 6, 2024
2 of 3 checks passed
@timkim timkim deleted the DEVSITE-466-Hero-Component-Displays-Scrollbar branch June 6, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants