Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added e2e tests for get credentials #1585

Merged
merged 88 commits into from
Jul 24, 2024
Merged

Conversation

deepessh
Copy link
Collaborator

@deepessh deepessh commented Jun 7, 2024

Description

Added e2e tests for get credentials component. Since the component needs to call console and TR APIs on stage, the tests need to run within corp network. For this, we setup a self-hosted github action runner. I have updated the job to use the self-hosted runner set up by @ronit1495.

Here's the list of changes in this PR:

  1. Added tests for api key and oauth s2s get credential component
  2. Added new dev:https:ci script to be able to run the development server using custom certificates stored in /example/certs folder
  3. Modified the e2e tests workflow to run inside docker, set the required env vars in /example/.env file
  4. Modified cypress config to include test user's email and pwd
  5. Added support functions to help with login
  6. Added data-cy attributes for making it easy to select elements in tests

Related Issue

https://jira.corp.adobe.com/browse/IOC-7681

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

BaskarMitrah and others added 30 commits May 8, 2024 21:18
* feat: wired up get template by id and install template endpoints

* fix: remove unused code

* Delete yarn.lock

---------

Co-authored-by: BaskarMitrah <113968869+BaskarMitrah@users.noreply.github.com>
* build : api integration & fixed design issue

* build : added edge cases

* -- Wired edge case in the RequestAccess

* fix: access token generation

* fix: show scrollbar

* fix: reorder error case handling

* fix: remove type1 edge case for api key credential

* Added allowed origins, Changed the building blocks for Restrictedaccessproducts

* Fixed the issue in download

* fix: do not check for org type in index.js

---------

Co-authored-by: BaskarMitrah <mit44186@adobe.com>
Co-authored-by: Manimaran Kottursamy <mit80447@adobe.com>
Co-authored-by: BaskarMitrah <mit44186@adobe.com>
container:
image: cypress/browsers:node-20.14.0-chrome-126.0.6478.114-1-ff-127.0.1-edge-126.0.2592.61-1
options: --user root
runs-on: self-hosted
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: For future reference, once IOXTD-2520 (more specifically IOXTD-2789) is completed, we'll have self-hosted runners on Ethos Corp-Connected Clusters so that we can replace use of this "temporary" self-hosted runner (see IOXTD-2788).

@timkim timkim merged commit 31838dc into main Jul 24, 2024
3 checks passed
@timkim timkim deleted the get_credential_phase2_e2e_tests branch July 24, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants