Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link text not indexing #1609

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix: link text not indexing #1609

merged 2 commits into from
Aug 7, 2024

Conversation

dmitrymatio
Copy link
Collaborator

@dmitrymatio dmitrymatio commented Aug 7, 2024

Description

Main fix of link text missing from search results by correctly mapping to the queried link's text value with

if (child.type === 'link') {
     return child?.children?.find(child => child.type === 'text')?.value;
}

Some minor formatting fixes.

Related Issue

Motivation and Context

How Has This Been Tested?

Tested within commerce-php repo where the issue was originally reported from by @dshevtsov

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkim timkim merged commit ec5969d into main Aug 7, 2024
3 checks passed
@timkim timkim deleted the fix-link-text-not-indexing branch August 7, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants