Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sticky feedback component #1610

Merged
merged 2 commits into from
Aug 9, 2024
Merged

feat: sticky feedback component #1610

merged 2 commits into from
Aug 9, 2024

Conversation

melissag-ensemble
Copy link
Collaborator

@melissag-ensemble melissag-ensemble commented Aug 9, 2024

Description

Make feedback component sticky by applying changes from AdobeDocs/commerce-webapi#269 to aio-theme

Related Issue

https://jira.corp.adobe.com/browse/DEVSITE-1070

Motivation and Context

  • User engagement increased significantly with sticky feedback component in an experiment done by commerce team
  • Devsite-team decided to make this the default design for the Feedback/MDXFilter component in the aio-theme:
Screenshot 2024-08-09 at 1 42 38 PM

How Has This Been Tested?

Screenshots (if appropriate):

Desktop:
Screenshot 2024-08-09 at 1 26 19 PM

Mobile:

Screenshot 2024-08-09 at 1 38 26 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@melissag-ensemble melissag-ensemble marked this pull request as ready for review August 9, 2024 20:47
@timkim timkim merged commit 8dcbc9e into main Aug 9, 2024
3 checks passed
@timkim timkim deleted the devsite-1070-sticky-feedback branch August 9, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants