Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redocly scroll y offset #1620

Merged
merged 1 commit into from
Oct 1, 2024
Merged

feat: redocly scroll y offset #1620

merged 1 commit into from
Oct 1, 2024

Conversation

melissag-ensemble
Copy link
Collaborator

@melissag-ensemble melissag-ensemble commented Sep 25, 2024

Description

Enable scrollYOffset config so user can adjust the top of the redocly page so that it doesn't overlap with the top nav.

Related Issue

https://jira.corp.adobe.com/browse/DEVSITE-1347
https://jira.corp.adobe.com/browse/DEVSITE-1308

Motivation and Context

Slack conversation: https://adobeio.slack.com/archives/C01GU3V8XE0/p1727220077882769

This serves two purposes:

How Has This Been Tested?

Page: https://developer-stage.adobe.com/redocly-test/api-full/#operation/getInventory
Src: AdobeDocs/redocly-test@29aa4d5#diff-ebd9ea94b0769347dd6343596cd0a667cbe2004d8c7a3cd952c4ae6d055f69d7R3

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@melissag-ensemble melissag-ensemble marked this pull request as ready for review September 25, 2024 15:11
@timkim timkim merged commit 5f59612 into main Oct 1, 2024
2 checks passed
@timkim timkim deleted the devsite-1347-scroll-y-offset branch October 1, 2024 19:45
timkim pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants