Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs : Credential component update #1622

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Bugs : Credential component update #1622

merged 11 commits into from
Oct 10, 2024

Conversation

BaskarMitrah
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@BaskarMitrah BaskarMitrah requested a review from timkim October 3, 2024 15:28
@timkim
Copy link
Collaborator

timkim commented Oct 3, 2024

Hmm seems there's a failing test: https://github.com/adobe/aio-theme/actions/runs/11164950891/job/31035481996?pr=1622#step:5:263

@BaskarMitrah
Copy link
Collaborator Author

Okay I'll check @timkim , Thanks

@timkim timkim merged commit afa017b into main Oct 10, 2024
3 checks passed
@timkim timkim deleted the bugs/credential-update branch October 10, 2024 18:43
timkim pushed a commit that referenced this pull request Nov 22, 2024
@BaskarMitrah @timkim
Bugs : Credential component update (#1622)
75faa40 
* Bugs : Credential component update

* Bug : Added test case for collapse button

* Bug : Remove return flow in API key

* Bug : Added return flow

* Bug : Fix the return flow issues

* Bug : Fix access edgecase button issues

* Fix : accessDetails-edgeCase-btn fail issue

* Fix : Restart button issue

* Fix : Generate token issue

* Fix : Test fail

* Fix : Credential details issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepessh deepessh deepessh left review comments

@timkim timkim timkim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BaskarMitrah @timkim @deepessh