Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pprof into the node API to debug memory leaks #67

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Conversation

sparshev
Copy link
Collaborator

@sparshev sparshev commented May 13, 2024

Integrated pprof to get profiling of the running Fish node - really helpful to understand what's inside causing bugs.

Tried to implement through pperf.Index(), but it's processing only handlers without the advanced calls like trace & profile... So implementation is a bit bigger then could be...

Related Issue

#64

Motivation and Context

In order to debug OOM's

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev added the enhancement New feature or request label May 13, 2024
@sparshev sparshev requested a review from svenevs May 13, 2024 21:18
@sparshev sparshev self-assigned this May 13, 2024
@sparshev sparshev added this to the v0.7.3 milestone May 13, 2024
Copy link
Collaborator

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of small fixes!

docs/openapi.yaml Outdated Show resolved Hide resolved
lib/openapi/api/api_v1.go Outdated Show resolved Hide resolved
@sparshev sparshev requested a review from svenevs May 15, 2024 15:55
svenevs
svenevs previously approved these changes May 15, 2024
Copy link
Collaborator

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

@sparshev sparshev merged commit efcaabc into main Jun 5, 2024
5 checks passed
@sparshev sparshev deleted the AF-64 branch June 5, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants