Add SSH Proxy #72
Merged
Add SSH Proxy #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create additional ResourceAccess and Authentication structures and related yaml to store in the database. - The only supported driver is VMX. All other drivers need to be taught about the new Authentication struct (in the future). - Add ProxySshAddress configuration variable to fish Config, the default value is `0.0.0.0:2022`. - Add corresponding SSH examples. This feature currently only supports SSH via username/password. See the new example label creation: ``` authentication: username: packer password: packer ``` When the fish node is running, you must query the application resource UID and request `/access` (see new run application example). These passwords are **one time use only**, in order to get a new password, re-request `/access`.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sparshev
requested changes
Jul 10, 2024
it is no longer a parameter
added new fish config var NodeSSHKey, chose Node prefix
since we could imagine "SSHKey" becoming overloaded / confusing
down the road. renaming might be needed
- cfg: NodeSSHKey
- file: ${node.name}_id_rsa
- file: ${node.name}_id_rsa.pub <unused, but still generated>
init() function and logging (aka flag not to delete it ever)
sparshev
requested changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SSH Proxy:
and related yaml to store in the database.
taught about the new Authentication struct (in the future).
default value is
0.0.0.0:2022.scpsucceeds, it hangs and must be ctrl+C'd.This is not getting fixed in this PR.
This feature currently only supports SSH via username/password.
See the new example label creation:
When the fish node is running, you must query the application
resource UID and request
/access(see new run applicationexample). These passwords are one time use only, in order
to get a new password, re-request
/access.Related Issue
Toward #61.
Motivation and Context
Step 1: get
username/passwordSSH proxy configured for VMX driver.How Has This Been Tested?
Rigorous local testing only.
Types of changes
Checklist: