Feature/285 #286
Merged
Feature/285 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While #285 was just for the Cart Modal, this fix updates the behavior for Download, and Share modals as well. |
davidjgonzalez
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #285
I thought about attempting to manage the state so that we don't always destroy the modal by default and thus do not need to re-request the modal from the server. This would add complexity and would need to uniquely identify the modal based on the type and asset path(s) in order to re-initialize it client side. It might not be used that much since the modal divs are removed upon page navigation and it is rare that a modal is the same.