This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Windows changes for File IO, File dialog and getElapsedMilliseconds. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #include <sys/stat.h> | ||
|
|
||
| // The global ClientHandler reference. | ||
| extern CefRefPtr<ClientHandler> g_handler; |
There was a problem hiding this comment.
I got this accidently checked in. I need this for QuitApplication().
|
|
||
| // Forward declarations for functions at the bottom of this file | ||
| void FixFilename(ExtensionString& filename); | ||
| void EscapeJSONString(const std::wstring& str, std::wstring& finalResult); |
There was a problem hiding this comment.
This declaration can be removed.
There was a problem hiding this comment.
Oops... I missed that in cleanup.
ghost
assigned Rename FixFilename to ConvertToNativePath. Add a new function ConvertToUnixPath for converting all selected files to unix path before returning them to JS layer. Remove all calls to FixFilename since we're now using unix path and Windows file IO can handle unix path. Not sure we may still need it for Win XP. Append a '/' to the end of a directory before calling _wstat().
|
Looks good! Merging. |
gruehle
added a commit
that referenced
this pull request
Jun 14, 2012
Windows changes for File IO, File dialog and getElapsedMilliseconds.
radorodopski
added a commit
to radorodopski/brackets-shell
that referenced
this pull request
Oct 24, 2014
This commit fixes a couple of things:
1. The list of icons was using relative paths.
2. If the icons could not be loaded, the error was ignored without a warning.
For adobe#1 I am prefixing the icon paths with the directory where the Brackets executable resides (since the icons are there, too).
One might think that the paths are relative to the aforementioned directory, except that is only true if Brackets is started from the launcher. If I start Brackets from the command line (or if I specify another initial working dir), Brackets fails to load the icons.
On top of that, no warning is issued to the user, making this hard to trace as my window manager cached the icons (so for testing I had to rename the executable, too). Which leads me to adobe#2, now I'm issuing a warning if Brackets fails to load any of the icons.
The bug was originally pointed out to me by another user - @orschiro on github.
gruehle
added a commit
that referenced
this pull request
Dec 8, 2015
Windows changes for File IO, File dialog and getElapsedMilliseconds.
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.