Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Fix potential crash when reloading Brackets #249

Merged
merged 1 commit into from
May 23, 2013
Merged

Conversation

gruehle
Copy link
Member

@gruehle gruehle commented May 23, 2013

When reloading Brackets, there is a short period of time where the old V8 context is still around, but has been detached from the browser. Any calls to our V8 extensions during that time will fail. Previously, this would crash. With this change, we simply ignore the request and return false to signal that we didn't handle the request.

@redmunds
Copy link
Contributor

Looks good. Merging.

redmunds added a commit that referenced this pull request May 23, 2013
Fix potential crash when reloading Brackets
@redmunds redmunds merged commit f791fb9 into master May 23, 2013
@redmunds redmunds deleted the glenn/crash-on-refresh branch May 23, 2013 22:10
redmunds added a commit that referenced this pull request Dec 8, 2015
Fix potential crash when reloading Brackets
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants