Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Support for chromium browser in linux #317

Merged
merged 1 commit into from
Aug 30, 2013
Merged

Support for chromium browser in linux #317

merged 1 commit into from
Aug 30, 2013

Conversation

macie
Copy link

@macie macie commented Aug 28, 2013

Replaced execl() by execlp() and added support for chromium browser.

@ghost ghost assigned jasonsanjose Aug 28, 2013
@jasonsanjose
Copy link
Member

Thanks @macie. I'll get to this for Sprint 31. Sprint 30 closes down today.

I think this a good interim solution until we have a way to set the desired browser in preferences. Great work!

@hollec
Copy link

hollec commented Aug 28, 2013

I believe this will help fix brackets issue #4720. As part of this support, should CloseLiveBrowser also be updated? It references the process google-chrome. At least on Ubuntu 13.04, when launching Chrome via the menu, the process I have running is chrome, launched via /opt/google/chrome/chrome. The google-chrome executable is still located at /usr/bin/google-chrome.

@jasonsanjose
Copy link
Member

Yes, @macie we should also update CloseLiveBrowser to close the same instance that was opened.

@macie
Copy link
Author

macie commented Aug 29, 2013

@jasonsanjose I looked up the code, but unfortunatly I still don't know what CloseLiveBrowser does (where is used) and how to close it in smart way.

@jasonsanjose
Copy link
Member

@macie it's used if the user already has Chrome open, but without debugging enabled --remote-debugging-port=9222. If we're in that state, we close the running instance of chrome relaunch with debugging enabled.

@jasonsanjose
Copy link
Member

Looks good. Merging.

@jasonsanjose
Copy link
Member

Tested with Chromium 28 on Ubuntu 13.04 64-bit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants