Don't add shortcuts that have a key available only when AltGr key is pressed. #446

RaymondLim · 2014-05-21T16:50:50Z

Also make sure that we don't show unavailable shortcuts in the menus. This fixes adobe/brackets#7859.

…pressed. Also make sure that we don't show unavailable shortcuts in the menus.

RaymondLim · 2014-05-22T20:06:48Z

Testing instructions:

Add either Czech or Croatian keyboard layout. See http://support.microsoft.com/kb/258824 for adding a new keyboard layout.
Launch your dev build of Brackets and when prompted to select index.html page, switch to CS or HR from Language Bar or the language icon in the Task Bar. This will ensure that Brackets is open with your desired keyboard layout.
If you're running Brackets w/o having to select index.html page, then you need to switch keyboard layout after launch and reloading it by press F5.
Try to use Ctrl+F or Ctrl+G and see FInd bar shows up.
Verify that Ctrl+[ and Ctrl+] shortcuts are not showing up under Edit menu.

redmunds · 2014-05-22T23:12:02Z

Looks good. Merging.

Don't add shortcuts that have a key available only when AltGr key is pressed.

JeffryBooher · 2014-05-23T03:57:59Z

appshell/appshell_extensions_win.cpp

@@ -1528,18 +1528,26 @@ bool UpdateAcceleratorTable(int32 tag, ExtensionString& keyStr)
                    // Get the virtual key code for non-alpha-numeric characters.
                    int keyCode = ::VkKeyScan(ascii);


We need to be careful about data types here so when we port to a 64-bit arch we don't have a lot to cleanup. That said, keyCode should be a SHORT as defined by Windows.

iegik · 2014-06-10T14:39:26Z

Related to adobe/brackets#8100

Don't add shortcuts that have a key available only when AltGr key is pressed.

Don't add shortcuts that have a key only available when AltGr key is …

6943048

…pressed. Also make sure that we don't show unavailable shortcuts in the menus.

JeffryBooher self-assigned this May 22, 2014

redmunds added a commit that referenced this pull request May 22, 2014

Merge pull request #446 from adobe/rlim/altGr-key-issue

c5cd588

Don't add shortcuts that have a key available only when AltGr key is pressed.

redmunds merged commit c5cd588 into master May 22, 2014

redmunds deleted the rlim/altGr-key-issue branch May 22, 2014 23:12

JeffryBooher reviewed May 23, 2014
View reviewed changes

RaymondLim mentioned this pull request May 26, 2014

Use the correct data type and MAPVK_VK_TO_CHAR constant from the WinSDK. #448

Merged

redmunds added a commit that referenced this pull request Dec 8, 2015

Merge pull request #446 from adobe/rlim/altGr-key-issue

2a58fe5

Don't add shortcuts that have a key available only when AltGr key is pressed.

This was referenced Aug 17, 2021

[CLOSED] Don't add shortcuts that have a key available only when AltGr key is pressed. brackets-archive/brackets-shell#291

Open

[CLOSED] Use the correct data type and MAPVK_VK_TO_CHAR constant from the WinSDK. brackets-archive/brackets-shell#293

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't add shortcuts that have a key available only when AltGr key is pressed. #446

Don't add shortcuts that have a key available only when AltGr key is pressed. #446

RaymondLim commented May 21, 2014

RaymondLim commented May 22, 2014

redmunds commented May 22, 2014

JeffryBooher May 23, 2014

iegik commented Jun 10, 2014

		@@ -1528,18 +1528,26 @@ bool UpdateAcceleratorTable(int32 tag, ExtensionString& keyStr)
		// Get the virtual key code for non-alpha-numeric characters.
		int keyCode = ::VkKeyScan(ascii);

Don't add shortcuts that have a key available only when AltGr key is pressed. #446

Don't add shortcuts that have a key available only when AltGr key is pressed. #446

Conversation

RaymondLim commented May 21, 2014

RaymondLim commented May 22, 2014

redmunds commented May 22, 2014

JeffryBooher May 23, 2014

Choose a reason for hiding this comment

iegik commented Jun 10, 2014