This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
[PROTOTYPE] Local HTTP-served static files, vs. file: protocol #475
+19,194
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept to serve brackets core www files over a static file HTTP node server.
After running into various issues with the security model (or lack of) in CEF combined with the issues when using the
file:
protocol, I thought it would be fun to see what it would take to serve Brackets over HTTP within brackets-shell using the built-in node server.Overall, this is not required for any current/planned features. However, I think it would help Brackets get closer to moving into the browser if we could transition away from
file:
first within brackets-shell.Changes:
appshell/node-core/Server.js
NodeConnection
to read the/api
JSON (i.e. http://localhost:[node_port]/api)appshell/node-core/thirdparty/conenct
static
middleware to serve filesThere's still more to do on the www side. We wouldn't need to shift to a node-based FS since we're in brackets-shell and can still access
brackets.fs
. However, a lot of www code (particularly extension loading) assumes afile:
URL. Here's the console log on init: