Don't Center Popups if Size and Width aren't parsed

[JeffryBooher]

@peterflynn

Fixes adobe/brackets#9597

[redmunds]

@JeffryBooher I'm seeing window correctly open at default size for these cases:

• window.open("about:blank")
• window.open("about:blank?height=400")

I was expecting window to open a default size for this case as well, but it still opens minimal window:

• window.open("about:blank?width=200")

[JeffryBooher]

@redmunds what does minimal window mean? I think the OS is positioning the window in all of three cases. What does Windows do if you create a window with a width but height is CW_USEDEFAULT?

[redmunds]

This is what I'm seeing for "default size" (click to see full size):

This is what I'm seeing for "minimal window" case:

[redmunds]

@JeffryBooher

What does Windows do if you create a window with a width but height is CW_USEDEFAULT?

I'm creating window from dev tools console, so CW_USEDEFAULT is not defined and get same result as "minimal window" case.

[JeffryBooher]

Yes I see it too.

You're specifying a Width for the Window but not a Height and passing CW_USEDEFAULT to CreateWindow. Since the signature for CreateWindow is: x, y, width, height, in that order, then my guess is when the default impl sees CW_USEDEFAULT for width it uses CW_USEDEFAULT for the height as well but if you don't specify CW_USEDEFAULT for width it expects a valid value for height.

CW_USEDEFAULT is declared as 0x80000000 which is a really small negative number (because the input parameter is signed) which windows would just create a window with the minimum window height in that case.

This seems like an edge case to me -- we could try to clean that up but it seems like this shouldn't be a case that we have to support.

[redmunds]

This is a question for @peterflynn (and maybe @jasonsanjose).

[JeffryBooher]

@redmunds no need to wait for @peterflynn -- I've pushed a fix for that case.

[redmunds]

LGTM. Merging.