This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Restoring the QUIT sequence on linux to that of CefClient #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the destroy() function call, which in turn calls CefQuitMessageLoop() as the right place to call this is inside ClientHandler::OnBeforeClose().
|
@ingorichter Please review this change |
|
@nethip Thank you. I will test this on the other branch jasonsj/cef_2171_linux. Most of the Linux related work happens currently there. |
|
Not needed anymore. See #619 |
This was referenced Aug 17, 2021
[CLOSED] [NOT READY] fix some linux compile issues with CEF 2171
brackets-archive/brackets-shell#322
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the destroy() function call, which in turn calls
CefQuitMessageLoop() as the right place to call this is inside
ClientHandler::OnBeforeClose().