This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Abose/win hi dpi hdc leak #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adobe/brackets/issues/10707: The function doesn't release the drawing context it uses to get the Device Capabilities which could lead to instability -- Windows will allocate memory for new ones (unless you change the CEF Window class to use a shared DC). Even though this is only called once per Window, each new Debugger Window, Popup window (PSDLens Cloud Login), or using Debug > New Brackets Window will create a new window and eventually Brackets will run out of handles.
|
LGTM @JeffryBooher Could you do a quick review of this and call out anything that is conspicuously wrong? |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue. adobe/brackets/issues/10707:
"The function below doesn't release the drawing context it uses to get the Device Capabilities which could lead to instability -- Windows will allocate memory for new ones (unless you change the CEF Window class to use a shared DC)."
Releasing dc after calculating DPI scaling.