VS2015: fix some warnings #549
Conversation
|
Nice to see someone working on the VS2015 support: it's one of the two pain points of not being able to contribute so much on the |
|
@ficristo Highly appreciate this. |
| } | ||
| psi->Release(); | ||
| IFileDialog *pfd; | ||
| if (SUCCEEDED(CoCreateInstance(CLSID_FileOpenDialog, NULL, CLSCTX_INPROC_SERVER, IID_PPV_ARGS(&pfd)))) { |
There was a problem hiding this comment.
Is the following code VS 2010 and VS 2013 neutral or does it have any hard dependency on VS 2105?
There was a problem hiding this comment.
I simply deleted the old code and reindented.
I don't think there should be any dependency on VS2015.
The code was platform dependent, so if that platforms are not supported anymore should be fine both on VS2010 and VS2015 (I hope 👅)
There was a problem hiding this comment.
Oh I did not pay close attention to the code being indented. Then I think it is just fine.
There was a problem hiding this comment.
If you add w=1 to an url on github you'll not see the whitespaces changes.
https://github.com/adobe/brackets-shell/pull/549/files?w=1
It can be useful to times like this
There was a problem hiding this comment.
@ficristo Thanks for the tip! That is sure useful.
|
Thanks @ficristo |
The warnings fixed were:
AFAICT the platforms supported are from Vista onwards: I removed the checks.
/cc @nethip