Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Improved console error messages #669

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Improved console error messages #669

merged 1 commit into from
Nov 18, 2019

Conversation

@g-217
Copy link
Contributor

@g-217 g-217 commented Nov 15, 2019

For --remote-debugging-port beyond allowed range, error message will be:

$ ./xcodebuild/Release/Brackets.app/Contents/MacOS/Brackets --remote-debugging-port=65535
[1115/144405:ERROR:cefclient.cpp(116)] Cannot enable remote debugging on port 65535. Port numbers should be between 1025 and 65534.

For --remote-debugging-port beyond parsing range of strtol, error message will be:

$ ./xcodebuild/Release/Brackets.app/Contents/MacOS/Brackets --remote-debugging-port=99999999999999999999
[1115/144412:ERROR:cefclient.cpp(104)] Could not enable remote debugging. Error while parsing remote-debugging-port arg: 99999999999999999999

@g-217
Copy link
Contributor Author

g-217 commented Nov 15, 2019

@niteskum @shubhsnov @narayani28

@niteskum
Copy link
Contributor

niteskum commented Nov 15, 2019

LGTM

@g-217
Copy link
Contributor Author

g-217 commented Nov 18, 2019

This is in continuation from PR #668

@vickramdhawal vickramdhawal merged commit cc28521 into adobe:master Nov 18, 2019
g-217 added a commit to g-217/brackets-shell that referenced this pull request Nov 18, 2019
@g-217
Improved console error messages (adobe#669)
340be0e
This was referenced Nov 18, 2019
Open
Merged
This was referenced Aug 17, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@g-217 @niteskum @vickramdhawal