Add whitelist and blacklist for extensions to use and ignore

adobe · Mar 27, 2015 · 0819785 · 0819785
1 parent a005b8a
commit 0819785
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/src/extensions/default/QuickView/main.js b/src/extensions/default/QuickView/main.js
@@ -460,9 +460,20 @@ define(function (require, exports, module) {
         var docPath = editor.document.file.fullPath;
         var imgPath;
 
-        if (PathUtils.isAbsoluteUrl(tokenString)) {
+        // Lists of common extensions that we know will and won't produce useful img resources
+        var extWhitelist = ['.gif', '.png', '.jpg', '.jpeg', '.svg', '.bmp'];
+        var extBlacklist = ['.json', '.htm', '.html', '.css', '.less', '.js', '.md', '.xml'];
+
+        var parsed = PathUtils.parseUrl(tokenString);
+        var protocol = parsed.protocol;
+        var ext = parsed.filenameExtension;
+
+        // Use this URL if this is an absolute URL and doesn't point to a blacklisted extension
+        if (protocol !== "" && extBlacklist.indexOf(ext) === -1) {
             imgPath = tokenString;
-        } else if (/(\.gif|\.png|\.jpg|\.jpeg|\.svg|\.bmp)$/i.test(tokenString)) {
+        }
+        // Use this filename if this is a path with a whitelisted extension
+        else if (protocol === "" && extWhitelist.indexOf(ext) > -1) {
             imgPath = "file:///" + FileUtils.getDirectoryPath(docPath) + tokenString;
         } else {
             return null;