Fixed ExtractToVariable Menu Close Issue due to scrolling (#14492)

* Fixed ExtractToVariable Menu Close Issue due to scrolling * Addressed Review Comments * Addessed review comments * Addressed Review Comments * Addressed Review Comments
adobe · Aug 2, 2018 · 0cee7d4 · 0cee7d4
1 parent afcbff0
commit 0cee7d4
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/extensions/default/JavaScriptRefactoring/ExtractToVariable.js b/src/extensions/default/JavaScriptRefactoring/ExtractToVariable.js
@@ -303,6 +303,19 @@ define(function(require, exports, module) {
                 inlineMenu = new InlineMenu(session.editor, Strings.EXTRACTTO_VARIABLE_SELECT_EXPRESSION);
 
                 inlineMenu.onHover(function (expnId) {
+                    // Remove the scroll Handlers If already Attached.
+                    editor.off("scroll.inlinemenu");
+                    // Add a scroll handler If Selection Range is not View.
+                    // This is Added for a Bug, where Menu used not to open for the first Time
+                    if(!editor.isLineVisible(editor.posFromIndex(expns[expnId].end).line)) {
+                        editor.on("scroll.inlinemenu", function() {
+                            // Remove the Handlers so that If scroll event is triggerd again by any other operation
+                            // Menu should not be reopened.
+                            // Menu Should be reopened only if Scroll event is triggered by onHover.
+                            editor.off("scroll.inlinemenu");
+                            inlineMenu.openRemovedMenu();
+                        });
+                    }
                     editor.setSelection(editor.posFromIndex(expns[expnId].start), editor.posFromIndex(expns[expnId].end));
                 });
 

diff --git a/src/widgets/InlineMenu.js b/src/widgets/InlineMenu.js
@@ -413,6 +413,19 @@ define(function (require, exports, module) {
         }
     };
 
+    /**
+     * Displays the last menu which was closed due to Scrolling
+     */
+    InlineMenu.prototype.openRemovedMenu = function () {
+        if (this.opened === true) {
+            if (this.$menu && !this.$menu.hasClass("open")) {
+                var menuPos = this._calcMenuLocation();
+                this.$menu.addClass("open")
+                    .css({"left": menuPos.left, "top": menuPos.top, "width": menuPos.width + "px"});
+            }
+        }
+    };
+
     /**
      * Closes the menu
      */