Merge pull request #12718 from ficristo/strict

ESLint: enable strict rule
adobe · Aug 25, 2016 · ad8e1ed · ad8e1ed
2 parents be62881 + 8370a08
commit ad8e1ed
Show file tree

Hide file tree

Showing 21 changed files with 1,294 additions and 1,299 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,7 +1,4 @@
 {
-    "env": {
-        "node": true
-    },
     "rules": {
         "no-bitwise": 0,
         "curly": 2,
@@ -25,7 +22,7 @@
         "no-control-regex": 2,
         "no-regex-spaces": 2,
         "no-undef": 2,
-        "strict": 0,
+        "strict": 2,
         "no-unused-vars": [0, {"vars": "all", "args": "none"}],
         "semi": 2,
 
@@ -59,6 +56,7 @@
         "$": false,
 
         "window": false,
+        "console": false,
         "setTimeout": false,
         "clearTimeout": false,
 

diff --git a/Gruntfile.js b/Gruntfile.js
@@ -21,11 +21,11 @@
  *
  */
 
+/*eslint-env node */
 /*jslint node: true */
+'use strict';
 
 module.exports = function (grunt) {
-    'use strict';
-
     // load dependencies
     require('load-grunt-tasks')(grunt, {
         pattern: [

diff --git a/src/LiveDevelopment/MultiBrowserImpl/launchers/node/LauncherDomain.js b/src/LiveDevelopment/MultiBrowserImpl/launchers/node/LauncherDomain.js
@@ -21,53 +21,50 @@
  *
  */
 
+/*eslint-env node */
 /*jslint node: true */
+"use strict";
 
-(function () {
-    "use strict";
+var open = require("opn");
 
-    var open = require("opn");
-
-    /**
-     * @private
-     * The Brackets domain manager for registering node extensions.
-     * @type {?DomainManager}
-     */
-    var _domainManager;
+/**
+ * @private
+ * The Brackets domain manager for registering node extensions.
+ * @type {?DomainManager}
+ */
+var _domainManager;
 
-    /**
-     * Launch the given URL in the system default browser.
-	 * TODO: it now launching just on default browser, add launchers for specific browsers.
-     * @param {string} url
-     */
-    function _cmdLaunch(url) {
-        open(url);
-    }
+/**
+ * Launch the given URL in the system default browser.
+    * TODO: it now launching just on default browser, add launchers for specific browsers.
+ * @param {string} url
+ */
+function _cmdLaunch(url) {
+    open(url);
+}
 
 
-    /**
-     * Initializes the domain and registers commands.
-     * @param {DomainManager} domainManager The DomainManager for the server
-     */
-    function init(domainManager) {
-        _domainManager = domainManager;
-        if (!domainManager.hasDomain("launcher")) {
-            domainManager.registerDomain("launcher", {major: 0, minor: 1});
-        }
-        domainManager.registerCommand(
-            "launcher",      // domain name
-            "launch",       // command name
-            _cmdLaunch,     // command handler function
-            false,          // this command is synchronous in Node
-            "Launches a given HTML file in the browser for live development",
-            [
-                { name: "url", type: "string", description: "file:// url to the HTML file" },
-                { name: "browser", type: "string", description: "browser name"}
-            ],
-            []
-        );
+/**
+ * Initializes the domain and registers commands.
+ * @param {DomainManager} domainManager The DomainManager for the server
+ */
+function init(domainManager) {
+    _domainManager = domainManager;
+    if (!domainManager.hasDomain("launcher")) {
+        domainManager.registerDomain("launcher", {major: 0, minor: 1});
     }
+    domainManager.registerCommand(
+        "launcher",      // domain name
+        "launch",       // command name
+        _cmdLaunch,     // command handler function
+        false,          // this command is synchronous in Node
+        "Launches a given HTML file in the browser for live development",
+        [
+            { name: "url", type: "string", description: "file:// url to the HTML file" },
+            { name: "browser", type: "string", description: "browser name"}
+        ],
+        []
+    );
+}
 
-    exports.init = init;
-
-}());
+exports.init = init;