Merge pull request #1395 from adobe/rlim/typing-issue-1394

Don't block keyPress events for charCode 33 and 34 (! and "). Let CodeMirror handles these.
adobe · Aug 17, 2012 · af6c1f9 · af6c1f9
2 parents acf9883 + 58beb2a
commit af6c1f9
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/editor/CodeHintManager.js b/src/editor/CodeHintManager.js
@@ -176,8 +176,9 @@ define(function (require, exports, module) {
         var keyCode = event.keyCode;
 
         // Up arrow, down arrow and enter key are always handled here
-        if (keyCode === 38 || keyCode === 40 || keyCode === 13 ||
-                keyCode === 33 || keyCode === 34) {
+        if (event.type !== "keypress" &&
+                (keyCode === 38 || keyCode === 40 || keyCode === 13 ||
+                keyCode === 33 || keyCode === 34)) {
 
             if (event.type === "keydown") {
                 if (keyCode === 38) {