Added error checks to the auto update mechanism. So in case the auto …

…update mechansim fails, we will now give chance to the default update process Handler to handle the update mechanism (Which is essentially taking the user to brackets.io). (#14605)
adobe · Dec 3, 2018 · fc2ebbe · fc2ebbe
1 parent cca4422
commit fc2ebbe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/extensions/default/AutoUpdate/main.js b/src/extensions/default/AutoUpdate/main.js
@@ -486,12 +486,12 @@ define(function (require, exports, module) {
 
             } else {
                 // Update not present for current platform
-                return;
+                return false;
             }
 
             if (!checksum || !downloadURL || !installerName) {
                 console.warn("AutoUpdate : asset information incorrect for the update");
-                return;
+                return false;
             }
 
             var updateParams = {

diff --git a/src/utils/UpdateNotification.js b/src/utils/UpdateNotification.js
@@ -512,7 +512,12 @@ define(function (require, exports, module) {
      */
     function handleUpdateProcess(updates) {
         var handler = _updateProcessHandler || _defaultUpdateProcessHandler;
-        handler(updates);
+        var success = handler(updates);
+        if (_updateProcessHandler && !success) {
+            // Give a chance to default handler in case
+            // the auot update mechanism has failed.
+            _defaultUpdateProcessHandler(updates);
+        }
     }
 
     /**