Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CSS Timing Function Quick Edit: linear is invalid syntax #10984

Closed
petetnt opened this issue Apr 23, 2015 · 1 comment · Fixed by #10989
Closed

CSS Timing Function Quick Edit: linear is invalid syntax #10984

petetnt opened this issue Apr 23, 2015 · 1 comment · Fixed by #10989
Milestone

Comments

@petetnt
Copy link
Collaborator

petetnt commented Apr 23, 2015

Steps to reproduce:

  • Create a .css file
.test {
  animation-timing-function: linear;
}
  • Place cursor on linear and press CTRL+E, which results in CSS Timing Function Quick Edit: invalid syntax.

Expected: Timing Function Quick Edit (Bezier curve editor?) view opens up with a line representing cubic-bezier(0.0, 0.0, 1.0, 1.0) (ref MDN).

Windows 8.1, Release 1.4 development build 1.4.0-0 (master 9264e29)

@petetnt
Copy link
Collaborator Author

petetnt commented Apr 23, 2015

This line states that:

// The linear keyword can occur in other values, so for strict parsing we
// only detect when it's on same line as "transition"

Checking for "animation" together with transition fixes the problem.

   LINEAR_STRICT_REGEX             = /transition|animation.*?[: ,]linear[ ,;]/,

I've got a PR ready that's ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@marcelgerber @petetnt and others