All source mixes quote styles

[rwaldron]

Brackets source code should consistently use double quotes for JS string literals and HTML attribute values. With one exception: if the code is inside a string literal (which already uses double quotes), use single quotes instead to avoid escaping.

The current codebase mostly follows these styles, but it's inconsistent in a few places.

Examples:

// JavaScript
var foo = "some text";
var htmlCode = "<div id='some-id' class='some-class'></div>";

<!-- HTML -->
<div id="some-id" class="some-class"></div>

---

original description:
I'm not advocating for either, but perhaps a definitive decision to use either single or double throughout the entire code base would be beneficial for maintainability.

[peterflynn]

Per our style guide all JS code should be using double quotes: https://github.com/adobe/brackets/wiki/Brackets%20Coding%20Conventions

[rwaldron]

Neat - style guides are boss :)

[pthiess]

Reviewed - we should use double quotes everywhere - leave it unassigned for now.

[glortho]

Does this apply to nested quotes as well? For example, should the single quotes below be converted to escaped double quotes or left as they are?

$("<div style='position:fixed;left:-50px;width:50px;height:50px;overflow:auto;'><div style='width:100px;height:100px;'/></div>")

Same question for these:

this.$htmlContent.append('<div class="shadow top"/>')

As this isn't explicit in the style guide, I personally prefer leaving the first one as is and changing the formatting of the second to match the first, but let me know and I'll make it happen.

[peterflynn]

+1 @jedverity

Although note that for HTML code in a real .html file, we do use double quotes -- so basically I think the proposal is that the outermost language in the file uses double quotes, while any language nested inside strings uses single quotes if possible.

[rwaldron]

FWIW, in the jQuery source and tests we use:

var html = "<div id='single-quotes-for-attributes'></div>";

Can we just use double quotes on the whole just to make everything look the same and clean?

[peterflynn]

@WesleMPennock: The proposal is to use double quotes everywhere, with just one exception: code nested inside a string literal. That seems more readable than using escaped double quotes. Compare:

var html = "<div id='some-id' class='some-class'></div>";
// vs.
var html = "<div id=\"some-id\" class=\"some-class\"></div>";

Does that seem fair to you, or are you saying you prefer the second form?

Oh I am sorry I misinterpreted the proposal, I prefer the first it is much more readable.

[peterflynn]

Ok, sounds like there's a pretty solid consensus then. I've updated the description at top, and I'll update the style guide to cover the nesting case too.

[JonathanWolfe]

I've done this issue with the pull request here (#1211).

I don't know how to attach a pull request to an issue though.

[redmunds]

Marking FBNC (fixed but not closed) so filer can verify fix.

[rwaldron]

LGTM

(If I come across any deviations, I'll post back here on the closed ticket)