Dialog telling you to reload Brackets in order to update extensions is no longer shown

[marcelgerber]

1. Open the Extension Manager
2. Update one of your extensions (if you don't have any extension to update, edit the package.json of one so it'll show an update. For example, change brackets-git's local version to 0.14.27)
3. Close the "Installation finished" dialog
4. Close the Extension Manager

Result: No dialog shown
Expected: A dialog telling you to restart Brackets in order to actually update the extensions should be shown

Bisecting brackets-shell pointed me to adobe/brackets-shell@fd6738a as the culprit.
cc @zaggino @abose @nethip

May be Windows only. Confirmed on Windows (10) and OS X (El Capitan)

Windows 10, brackets-shell@release-1.4 (both custom built and downloaded one)

[marcelgerber]

That's what it used to look like (Release 1.3 shell):

That's what it looks like now (Release 1.4 shell):

Look for the different values of installationStatus. It looks like ExtensionManager.updateFromDownload is now called later in time.

[zaggino]

@marcelgerber can you check the PR?

[abose]

#11553 PR for fix to the issue.