Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Drawing of alert box broken and not big enough (at least on Windows XP) #2112

Closed
DennisKehrig opened this issue Nov 14, 2012 · 21 comments
Closed

Comments

@DennisKehrig
Copy link
Contributor

Screenshot

The last one indicates that parts of the screen are simply not drawn. It was taken after changing the theme, part of what Windows was drawing is still in the buffer there.

@peterflynn
Copy link
Member

I think there's a similar problem with confirm(), but I can't find the bug number offhand...

@ghost ghost assigned DennisKehrig Nov 15, 2012
@pthiess
Copy link
Contributor

pthiess commented Nov 15, 2012

Reviewed, assigned to @DennisKehrig , we probably need to file a bug against CEF.

@DennisKehrig
Copy link
Contributor Author

Goes back to Sprint 13, i.e. when we switched to the new shell.

@DennisKehrig
Copy link
Contributor Author

This is CEF issue #760. Unfortunately, there's no fix in sight.

@njx
Copy link

njx commented Nov 21, 2012

OK. Let's leave it at "tracking" for now and wait to see if they do anything about it.

@njx
Copy link

njx commented Nov 21, 2012

@DennisKehrig -- could you post a comment to the bug just so they know more people are being affected by this? Thanks.

@DennisKehrig
Copy link
Contributor Author

@njx Sure, it's done!

@custa1200
Copy link

Are Adobe people working on any issues and submitting them as patches back to CEF as part of this or other projects?

@njx
Copy link

njx commented Nov 21, 2012

Yes--the bulk of our contributions have been to CodeMirror, but I believe we've submitted a few bugfixes to CEF as well.

@custa1200
Copy link

Good to hear that my Cloud subscription is helping contribute to the CEF project. :)

@DennisKehrig
Copy link
Contributor Author

Screenshot

This seems to happen with menus, too, The help menu has a white border because I hovered the mouse cursor over it shortly before.

@peterflynn
Copy link
Member

@DennisKehrig what OS are you on? Menu rollovers look fine for me on Win XP & 8. But I notice the titlebar has a non-default appearance... are you running some sort of custom visual theme? Or is that just one of the non-"glass" Vista themes?

@DennisKehrig
Copy link
Contributor Author

It's XP with the Luna Royale theme. Not sure where that is from originally, but I haven't seen this problem in any other applicaation.

@DennisKehrig
Copy link
Contributor Author

Curious, I changed the theme to Windows classic, then back to Luna Royale, and the problem is gone (even across Brackets restarts). Before, not even Windows restarts fixed it. But obviously it's not easy to reproduce, then...

@peterflynn
Copy link
Member

Sounds like that should be broken out as a separate bug -- I'm pretty sure it's unrelated to the alert() box problem.

@DennisKehrig
Copy link
Contributor Author

I'm not so sure, since it's also about stuff not being properly redrawn. But I'll do that should it return - until then I have no idea how we could diagnose let alone fix this.

@ghost
Copy link

ghost commented Jan 31, 2013

Hi i am new to github and was going to post about this as it's happening for me also. If i use alert("") then the popup it makes cannot be closed with it's top right close icon and also the button is hidden and i only see the very top of it like the images posted here. I use Windows XP with the default "Energy Blue" theme and some modified settings like no animation but i don't think this is a issue caused by the themes.

Before i realized the button was just about clickable i was having to force Brackets to close but it would be nice if it appeared the same way as it does with a regular browser.

Edit - I am not sure if it makes any difference as i don't know how often it is updated but i used the installer rather than building myself but issue is happening every time i use alert("") in extensions.

@ghost
Copy link

ghost commented Jan 31, 2013

This is what i see if anyone was interested -

Alert Error

@DennisKehrig
Copy link
Contributor Author

Curious that the Close button doesn't work, but I can confirm it.
You can however still hit Enter or Space to press the OK button.

@DennisKehrig
Copy link
Contributor Author

If I read the comment in the bugtracker correctly, this will be fixed with the "next" CEF release. Yay!

@njx
Copy link

njx commented Apr 14, 2014

Closing - we don't use native alert dialogs in Brackets anyway and XP is not a huge proportion of our user base.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants