Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Drawing of alert box broken and not big enough (at least on Windows XP) #2040

Open
core-ai-bot opened this issue Aug 29, 2021 · 21 comments

Comments

@core-ai-bot
Copy link
Member

Issue by DennisKehrig
Wednesday Nov 14, 2012 at 12:03 GMT
Originally opened as adobe/brackets#2112


Screenshot

The last one indicates that parts of the screen are simply not drawn. It was taken after changing the theme, part of what Windows was drawing is still in the buffer there.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Nov 14, 2012 at 18:21 GMT


I think there's a similar problem with confirm(), but I can't find the bug number offhand...

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Thursday Nov 15, 2012 at 17:46 GMT


Reviewed, assigned to@DennisKehrig , we probably need to file a bug against CEF.

@core-ai-bot
Copy link
Member Author

Comment by DennisKehrig
Wednesday Nov 21, 2012 at 13:54 GMT


Goes back to Sprint 13, i.e. when we switched to the new shell.

@core-ai-bot
Copy link
Member Author

Comment by DennisKehrig
Wednesday Nov 21, 2012 at 13:58 GMT


This is CEF issue #760. Unfortunately, there's no fix in sight.

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Nov 21, 2012 at 17:15 GMT


OK. Let's leave it at "tracking" for now and wait to see if they do anything about it.

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Nov 21, 2012 at 17:16 GMT


@DennisKehrig -- could you post a comment to the bug just so they know more people are being affected by this? Thanks.

@core-ai-bot
Copy link
Member Author

Comment by DennisKehrig
Wednesday Nov 21, 2012 at 17:21 GMT


@njx Sure, it's done!

@core-ai-bot
Copy link
Member Author

Comment by custa1200
Wednesday Nov 21, 2012 at 21:04 GMT


Are Adobe people working on any issues and submitting them as patches back to CEF as part of this or other projects?

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Nov 21, 2012 at 21:46 GMT


Yes--the bulk of our contributions have been to CodeMirror, but I believe we've submitted a few bugfixes to CEF as well.

@core-ai-bot
Copy link
Member Author

Comment by custa1200
Wednesday Nov 21, 2012 at 22:03 GMT


Good to hear that my Cloud subscription is helping contribute to the CEF project. :)

@core-ai-bot
Copy link
Member Author

Comment by DennisKehrig
Monday Jan 28, 2013 at 16:47 GMT


Screenshot

This seems to happen with menus, too, The help menu has a white border because I hovered the mouse cursor over it shortly before.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Jan 28, 2013 at 20:02 GMT


@DennisKehrig what OS are you on? Menu rollovers look fine for me on Win XP & 8. But I notice the titlebar has a non-default appearance... are you running some sort of custom visual theme? Or is that just one of the non-"glass" Vista themes?

@core-ai-bot
Copy link
Member Author

Comment by DennisKehrig
Monday Jan 28, 2013 at 20:07 GMT


It's XP with the Luna Royale theme. Not sure where that is from originally, but I haven't seen this problem in any other applicaation.

@core-ai-bot
Copy link
Member Author

Comment by DennisKehrig
Monday Jan 28, 2013 at 20:09 GMT


Curious, I changed the theme to Windows classic, then back to Luna Royale, and the problem is gone (even across Brackets restarts). Before, not even Windows restarts fixed it. But obviously it's not easy to reproduce, then...

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Jan 28, 2013 at 20:15 GMT


Sounds like that should be broken out as a separate bug -- I'm pretty sure it's unrelated to the alert() box problem.

@core-ai-bot
Copy link
Member Author

Comment by DennisKehrig
Monday Jan 28, 2013 at 20:20 GMT


I'm not so sure, since it's also about stuff not being properly redrawn. But I'll do that should it return - until then I have no idea how we could diagnose let alone fix this.

@core-ai-bot
Copy link
Member Author

Comment by coderatom
Thursday Jan 31, 2013 at 15:55 GMT


Hi i am new to github and was going to post about this as it's happening for me also. If i use alert("") then the popup it makes cannot be closed with it's top right close icon and also the button is hidden and i only see the very top of it like the images posted here. I use Windows XP with the default "Energy Blue" theme and some modified settings like no animation but i don't think this is a issue caused by the themes.

Before i realized the button was just about clickable i was having to force Brackets to close but it would be nice if it appeared the same way as it does with a regular browser.

Edit - I am not sure if it makes any difference as i don't know how often it is updated but i used the installer rather than building myself but issue is happening every time i use alert("") in extensions.

@core-ai-bot
Copy link
Member Author

Comment by coderatom
Thursday Jan 31, 2013 at 18:06 GMT


This is what i see if anyone was interested -

Alert Error

@core-ai-bot
Copy link
Member Author

Comment by DennisKehrig
Monday Feb 04, 2013 at 11:17 GMT


Curious that the Close button doesn't work, but I can confirm it.
You can however still hit Enter or Space to press the OK button.

@core-ai-bot
Copy link
Member Author

Comment by DennisKehrig
Monday Mar 11, 2013 at 10:24 GMT


If I read the comment in the bugtracker correctly, this will be fixed with the "next" CEF release. Yay!

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Apr 14, 2014 at 18:53 GMT


Closing - we don't use native alert dialogs in Brackets anyway and XP is not a huge proportion of our user base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant