Can lose changes by accidentally clicking where file sync from disk dialog will appear

[peterflynn]

1. Make some edits in Brackets -- don't save your changes yet
2. Leave Brackets and modify (or delete) the same file on disk
3. Return to Brackets -- you'll get a prompt about keeping your editor changes vs. refreshing from disk
4. Put your finger on the computer screen where the destructive button is (the 'lose editor changes' button)
5. Click the other button to keep your changes for now... but keep your finger in place
6. Switch to a different app, but leave the Brackets window uncovered
7. Move the mouse to where your finger is, and click in the Brackets window

Result: your editor changes have been blown away without warning

This happens because the window gains activation on mousedown, and the dialog appears... and then the mouseup triggers the button in the dialog.

Note that these long repro steps are needed only to reliably hit the bug. You could hit this by accident -- by clicking in an unlucky spot -- just by doing steps 1,2,7.

In theory, any asynchronous process that spawns a popup dialog without user interaction could have this same issue. So hopefully there's a generic solution for this we can put into Dialog.

[julianasuh]

QRB - Marking as Low Priority

[njx]

QRB reviewed

[peterflynn]

Nominating for 1.0 -- although we don't hear complaints about this often (other than causing some confusion during testing in Sprint 35), the prospect of data loss is real and fixing it should be easy.

[marcelgerber]

@peterflynn I can't reproduce this any more on Win - The dialog can be easily seen while the window is inactive (but uncovered).
Are you sure that's still a problem?

[pthiess]

@peterflynn Since this is data loss but low frequency and we should do it for 1.0 if its an easy fix, so please time box it down to an hour or so.