Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Pressing [Enter] in Extension Manager Search box closes Extension Manager #6904

Closed
ashmind opened this issue Feb 18, 2014 · 12 comments
Closed

Comments

@ashmind
Copy link

ashmind commented Feb 18, 2014

Steps to reproduce:

  1. Open Extension Manager
  2. Place focus in the Search box
  3. (Optional) Type any text
  4. Press Enter

Expected result:
Nothing happens. Since a lot of search boxes in web and desktop only search on Enter, it is natural to press Enter after typing. If the search is immediate, Enter should do nothing.

Actual result:
Extension Manager closes without doing anything, so I have to reopen it and re-type my search.

Environment:

  • Windows 7
  • Brackets Sprint 36 experimental build 0.36.0-11506 (release 942505c)
@marcelgerber
Copy link
Contributor

This is because every dialog (the Extension Manager is just a simple dialog) closes on Enter, doing the thing the default (blue) button does.
But your right, I think this should be disabled/improved in the extension manager.

@dangoor
Copy link
Contributor

dangoor commented Feb 24, 2014

Reviewed low priority to @ingorichter

@redmunds
Copy link
Contributor

This is very similar to #3858 (except using Esc key), so they should probably be merged into a single issue.

@luto
Copy link

luto commented May 12, 2014

+1

@codeofsumit
Copy link

+1. Very annoying.

@redmunds
Copy link
Contributor

redmunds commented Oct 2, 2014

Pull request #7337 with commit 081a1ad has not yet been merged, so changing this back to Fix in Progress.

@dmitryverkhovtsev
Copy link

+1

@FezVrasta
Copy link
Contributor

Any news on this?

@abose
Copy link
Contributor

abose commented Dec 22, 2015

Tagging @rroshan1 for extension manager improvements.

@niklasHagner
Copy link

+1 I'm having issues with this all the time

@Denisov21
Copy link
Contributor

+1

@petetnt
Copy link
Collaborator

petetnt commented Oct 18, 2016

Fixed in #12839

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

16 participants