Can't create new folder in the place you would expect (under the root directory in one case)

[aadamsx]

On Sprint 38 I cannot create a new Folder under the Root directory without first selecting a file handing off that directory.

For example,

If I right-click -- in the open area of the sidebar -- under Root > select New Folder >

Option 1) And the preexisting sidebar highlight item is a folder > the new folder will be created under that highlighted folder. ** even though I right clicked another area on the sidebar **

Option 2) And the preexisting sidebar highlighted item is a file under root > the new folder will be created under root. ** this is fine I suppose **

If I right-click -- in a folder on the side bar > select New Folder > and the preexisting highlighted object was another folder, the New Folder action will create a new folder not in the directory I'm right-click-selecting, but in the preexisting highlighted item.

The issue is, it should not matter what was highlighted before I right-clicked in an open area of the sidebar. The application should know that where ever I right-click should be the spot I want the new folder (or in another way, the object I want to take action on), not the highlighted object. In fact I would say what you right click on should then become the highlighted object (they should not be independent).

I didn't test all use cases, just a couple. I hope this makes sense.

Please let me know if I can help test this further.

Thank you --

[njx]

Low pri to me. I can reproduce some of these issues, but need to clarify a couple of cases - in particular, if the previously selected object was itself a folder, I don't see the bug, but if the previously selected object was a file in a folder, then I do see the bug. @aadamsx - can you confirm that that's the issue?

[njx]

The overall problem seems to be that if you don't have a visible selection in the tree (because the selected file is in the working set), we still think of the selection as being in the folder that contains that file, even though it's not visibly selected in the tree. When that happens, the primary bug seems to be that right-clicking in the blank space below the tree and selecting "New Folder" creates the folder next to that file instead of at the root, which is confusing.

I wasn't able to reproduce the issue of right-clicking on another folder and selecting "New Folder" creating the folder in the previous folder. @pthiess thought he saw it, but on trying to repro it seemed to be doing the right thing. @aadamsx, if you can give specific steps for that case, please let us know.

[Nullpo]

Maybe this can help:

The expected behavior is to create a new file into the project's root folder.

[njx]

@dangoor - something to think about as you work on the new file tree.

[dangoor]

This is fixed by #8788. When you right click, that determines where the "context" is independent of the selected file and that determines where new files/folders are created.

[dangoor]

@aadamsx This is fixed in master and in the forthcoming release 0.44 (which has a prerelease available). By "fixed", I mean that right-clicks select the context independent of the current open file. The one catch is covered by #9341 - if you click in the open area in the sidebar it will still default to the current selected file (look at that issue for the considerations there).

I'll close this issue. Feel free to reopen if you think there's something else remaining for this issue that is not covered by #9341.

[CodeAmend]

The ONLY way that I know to make a new folder in the root is you have to select a file in the root. What if there is no file to select? If that is the case, I cannot find a way to create a new folder. So I make a dummy file, right click it and make a new folder, then delete file. Kinda silly :)