This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Removing the unneeded negative margin trick used to position icons. #10002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .jstree-brackets li > a { | ||
| @jstree-icon-text-overlap: 2px; | ||
| padding-left: (@jstree-sprite-size - @jstree-icon-backindent - @jstree-icon-text-overlap + 10000px); | ||
| margin-left: -10000px; | ||
| padding-left: (@jstree-sprite-size - @jstree-icon-backindent - @jstree-icon-text-overlap); |
There was a problem hiding this comment.
This looks good as a fix/workaround for #9965.
|
@peterflynn Ok, I backed out the code that removes the focus ring. Ready for review. |
|
Closing in favor of a new pull request #10011. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #9965.
I also fix #9987 in this pull request since it is showing the left edge of the focus ring with the fix for #9965.