Ensure that the baseDir for createNewItem is within the project.

[dangoor]

This is a fix for #9910.

[busykai]

@dangoor, while reviewing and testing this. I'm curious, which code was triggering the project tree redraw?

[le717]

Hehe, I needed this functionality (getDirectoryInProject()) in my extension a few months ago. I would pull in a path in my project but it would sometimes pull a fuller, incorrect path.

[busykai]

This should return right away.

[RaymondLim]

No, we can't just return null. We need to fix it below to the project root since the caller is expecting a valid directory in the project.

[dangoor]

Yep, this function always returns a valid directory in the project.

[busykai]

👍 got it

[RaymondLim]

LGTM. Merging.

[dangoor]

@busykai the project tree redraws any time the view model changes.

[busykai]

@dangoor, I was trying to understand why the project root in the model would shift, hence the question. thanks!

[dangoor]

@busykai I didn't dive into that, but my guess is that the absolute path was sent all the way through, so the FileTreeViewModel then had to account for all of those extra directories. You do raise a good question, though: it would likely be better for that absolute path to be rejected at that point that it was introduced. The fix in this pull request is still the right fix for this particular problem, because when you create a file or directory by clicking in the blank space it should create the new item in the project rather than rejecting.