This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
#10071 bash detection for extensionless file #10141
Open
gklo
wants to merge
7
commits into
adobe:master
Choose a base branch
from
gklo:10071-bash-detection-for-extensionless-file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−6
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9bc5830
inital implementation of bash script detection for extensionless file
gklo f653bfd
Minor fix
gklo e197be1
Added regexp string to language object for content detection
gklo 5601610
Syntax fixes
gklo bf84375
implement general script language(shebang) detection and remove autoD…
gklo 56cbbdd
update test spec for auto detection
gklo 722b16e
remove rawText arg from getLanguageForPath()
gklo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is called from other places that won't pass
rawText
(e.g._notifyFilePathChanged()
,DocumentManager._handleLanguageAdded()
, etc.). Will the behavior be correct then? It safer & simpler to remove the arg and just invokethis.getText()
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But also... since this is called in multiple cases, various actions will trigger a "re-check" of the document's text. If the user edits the document to add/remove the shebang, at what point would they expect the document to switch to/from Bash mode? We should make sure that feels predictable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe
this.getText()
won't exist cause the functions are called byDocument
constructor. Therefore, usingrawText
is probably the best way to pass the contents toLanguageManager
. So far, the shebang detection happens only when user opens a file, I am not sure about the "re-check" triggers during editing. Could you or anybody help me for that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and yes
rawText
can be null, so_updateLanguage()
can be called withoutrawText
.