-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
@@ -22,7 +22,7 @@ | |||
DEALINGS IN THE SOFTWARE. | |||
--> | |||
|
|||
<html> | |||
<html spellcheck="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ick. Any way to fix this in CSS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link has a way to do it in JavaScript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RaymondLim Your solution works only for static pages, where all input/textarea fields are already existent on pageload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @RaymondLim was suggesting to use that technique to apply spellcheck="false"
to the html
tag so it's not hard-coded in index.html. Probably only need to apply it to the body
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@redmunds I think it's actually nicer to do keep it in the declarative markup. Why do it in JS if there's nothing dynamic about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a CEF-only issue, so it doesn't apply to other configurations (e.g. in-browser). I also would rather not clutter the HTML markup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@redmunds It's not CEF specific afaik -- spell checking is a feature in most modern browsers, we just didn't see it before since our version of Chromium was so old :-/ I see the same behavior when running Brackets in-browser in Chrome, and presumably Safari & FF at least would be the same.
I feel this is fine to leave the This would be good candidate for 1.3. |
@nethip This is pretty ugly, so I agree this fix should be merged for 1.3. |
Thanks @marcelgerber |
For #10241