This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Send the error over to the callback if decompress-zip fails #10343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. The formatting in the error dialog needs to be updated to provide a better location for the error message. |
ingorichter
added a commit
that referenced
this pull request
Jan 14, 2015
Send the error over to the callback if decompress-zip fails
|
I don't think there's a need to change the Brackets-internal error message (AFAIK, contrary to the registry, it only ever shows up when there's a real problem with the zip). And changing the server-side error message is part of adobe/brackets-registry#69. |
|
I meant more the formatting of the error dialog. The error message could be more separated from the remaining text of the dialog box. |
|
So, do you mean the error dialog in Brackets itself or in the registry? |
|
The error dialog in Brackets |
|
|
|
@ingorichter Would you like to do the change or should I do it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for adobe/brackets-registry#69.