This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Clean-up servers when closing LiveDevelopment #10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for adobe#10374. LiveDevMultiBrowser can't load when a local server is configured. Servers registered by LiveDevelopment are now being cleaned-up when closing the session.
|
@busykai Would you mind taking a look at this PR? |
|
@nethip, sure! will do (next week, most likely). |
| @@ -188,6 +188,11 @@ define(function LiveDevelopment(require, exports, module) { | |||
| * @type {BaseServer} | |||
| */ | |||
| var _server; | |||
|
|
|||
| /** | |||
| * Handlers of registered servers | |||
|
@sebaslv, done with the review. Just these minor comments. |
Address comments from review.
|
@kai, I've already included those changes. Thanks! |
|
someone named 'kai' got surprised. :) |
|
LGTM. Merging. |
busykai
added a commit
that referenced
this pull request
May 14, 2015
Clean-up servers when closing LiveDevelopment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10374
LiveDevMultiBrowserfails to connect when a local server is configured.Servers registered by
LiveDevelopmentare now being cleaned-up when closing the session sinceLiveDevServerManagerretrieves an instance ofUserServertoLiveDevMultiBrowserin this case.In order to be able to remove registered servers, a new
LiveDevServerManager.removeServer(provider)operation was added andLiveDevServerManager.registerServer()now returns an object handler to be used for removing it. Registrations of servers atLiveDevelopmentwere moved frominit()toopen()and clean-up of servers take place atLiveDevelopment.close().