[#10228] Cmd+Delete now triggers Don't Save in Save Changes dialog #10459
Conversation
| @@ -180,7 +180,7 @@ define(function (require, exports, module) { | |||
| } | |||
| } else if (brackets.platform === "mac") { | |||
| // CMD+D Don't Save | |||
There was a problem hiding this comment.
You should rather call this CMD+Delete, right?
Also, I think CMD+D still should trigger Don't Save, shouldn't it?
There was a problem hiding this comment.
Hello Marcel,
according to Apple CMD-Backspace is the default for Don't Save. Or did I got it wrong :/
Anyhow I have updated the comment. Thanks for the tip.
Regards,
Lucas L.
On 01 Feb 2015, at 14:29, Marcel Gerber <notifications@github.com mailto:notifications@github.com> wrote:
In src/widgets/Dialogs.js #10459 (comment):
@@ -180,7 +180,7 @@ define(function (require, exports, module) {
}
} else if (brackets.platform === "mac") {
// CMD+D Don't Save
You should rather call this CMD+Delete, right?
Also, I think CMD+D still should trigger Don't Save, shouldn't it?—
Reply to this email directly or view it on GitHub https://github.com/adobe/brackets/pull/10459/files#r23897530.
There was a problem hiding this comment.
From what I can tell (not that I have a Mac...), it's Cmd+Delete:
There was a problem hiding this comment.
Hello,
Apple keyboards sometimes have only one key for deletions (that is, one key that acts as a backspace and delete key). This key is located on the upper right corner of the keyboard. For instance on my MacBook Pro its labeled 'Delete' and on my wireless Apple keyboard it is just labeled with a left pointing arrow ('<----'). So hitting CMD+Backspace/Delete triggers the Don't Save action.
CMD+D is also bind on the "Duplicate" action in Brackets and doesn't seem to trigger Don't Save at all under the Mac.
I have tested the Don't Save behaviour on Apple's standard apps (like TextEdit, Preview) and CMD+D doesn't seem to trigger Don't Save either.
Whereas CMD+Backspace does.
Best Regards,
Lucas
On 01 Feb 2015, at 15:13, Marcel Gerber notifications@github.com wrote:
In src/widgets/Dialogs.js #10459 (comment):
@@ -180,7 +180,7 @@ define(function (require, exports, module) {
}
} else if (brackets.platform === "mac") {
// CMD+D Don't Save
From what I can tell (not that I have a Mac...), it's Cmd+Delete:
https://cloud.githubusercontent.com/assets/2641501/5992320/ba5a6c92-aa24-11e4-8bd8-00da4d6168f9.png
—
Reply to this email directly or view it on GitHub https://github.com/adobe/brackets/pull/10459/files#r23897756.
There was a problem hiding this comment.
Ah ok, didn't know that. As stated above, I don't own a Macbook.
There was a problem hiding this comment.
Yeah, at least with the keyboards that I own from Apple that is the case. If I'm not mistaken, on older versions of Mac OS X
the Don't Save action was bound to CMD+D... but not anymore :\
On 01 Feb 2015, at 15:57, Marcel Gerber <notifications@github.com mailto:notifications@github.com> wrote:
In src/widgets/Dialogs.js #10459 (comment):
@@ -180,7 +180,7 @@ define(function (require, exports, module) {
}
} else if (brackets.platform === "mac") {
// CMD+D Don't Save
Ah ok, didn't know that. As stated above, I don't own a Macbook.—
Reply to this email directly or view it on GitHub https://github.com/adobe/brackets/pull/10459/files#r23898065.
|
@lucaslouca It sounds like some Mac apps use Cmd-D also (e.g. #283 mentions this), so this should probably be Also, could you squash this down to one commit? 3-4 commits for a single-line change makes the git history a little sloppy. Looks great otherwise though! |
|
Ah, I forgot that the existing Cmd-D code has been broken for a long time, due to conflicting with a menubar shortcut (see #4135 / scoped keybindings story). So this actually looks fine as is -- if you can just squash the commits, I think we can go ahead & merge. |
Fix memory leak in CSS & SVG Code Hints Clicking an Extension Manager tab while still loading will show it Use function to clear search Code review changes Change font weight of menu items to be 'normal' instead of 200, to improve readability. Changed comment to apply for CMD+Backspace [#10228] Cmd+Delete now triggers Don't Save in Save Changes dialog
|
Hello, done :) On 2015-03-01 09:04, Peter Flynn wrote:
|
|
Looks good -- thanks! |
[#10228] Cmd+Backspace now triggers "Don't Save" dialog button
Cmd+Delete (Mac) now triggers Don't Save in Save Changes dialog. This is the system's default behaviour (see http://support.apple.com/en-us/HT201236).
(Issue #10228)