Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Change 'split selection into lines' shortcut on Linux #10742

Merged
merged 1 commit into from
Mar 25, 2015

Conversation

Projjol-zz
Copy link
Contributor

Current combination is a system default for locking the machine/ standby. New combination follows convention used by other editors and should work without affecting any system defaults.

Current combination is a system default for locking the machine/ standby. New combination follows convention used by other editors and should work without affecting any system defaults.
@peterflynn peterflynn changed the title Update keyboard.json Change 'split selection into lines' shortcut on Linux Mar 16, 2015
@peterflynn
Copy link
Member

Changed to less ambiguous title

@@ -71,7 +71,13 @@
}
],
"edit.splitSelIntoLines": [
"Ctrl-Alt-L"
{
"key": "Ctrl-Alt-L"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Ctrl+shift+L in all platforms so that it works uniformly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abose I think we should not change the shortcut key without any strong reasons because users are accustomed to the shortcut keys in Brackets and changing any will not be received gladly by users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prafulVaishnav are you suggesting that it should not be changed for any platform or that it's changed for Linux while the other systems remain the same?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Projjol I think he meant change the shortcut only for linux, which sounds ok to me. I have seen different key bindings for the same command on different platforms in other cases as well (Moving line up / down). So this change should be fine as well

prksingh added a commit that referenced this pull request Mar 25, 2015
Change 'split selection into lines' shortcut on Linux
@prksingh prksingh merged commit 46ba092 into adobe:master Mar 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants