Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Allow CSS Code Hints in PHP files #11635

Closed
wants to merge 1 commit into from
Closed

Allow CSS Code Hints in PHP files #11635

wants to merge 1 commit into from

Conversation

sprintr
Copy link
Contributor

@sprintr sprintr commented Aug 27, 2015

Allow CSS Code Hints in style tags for PHP files. Fixes #11629

@marcelgerber
Copy link
Contributor

There are 3 more occurences of ctx.token.state in https://github.com/sprintr/brackets/blob/2e64c0dfd7ec8b15365438068720ce1fa59df480/src/language/CSSUtils.js#L1583-L1592

Please try to fix those as well. In my opinion, a helper function _getState would fit all cases the best.

@sprintr sprintr changed the title Fixes #11629 Allow CSS Code Hints in PHP files Aug 30, 2015
@abose
Copy link
Contributor

abose commented Sep 15, 2015

Tagging @marcelgerber for review.

@marcelgerber
Copy link
Contributor

@sprintr There are still 3 occurences of ctx.token.state. You should either switch them over to _getState(), or state that they should not be changed for some reason.

@sprintr
Copy link
Contributor Author

sprintr commented Sep 27, 2015

Closing in favor of #11751

@sprintr sprintr closed this Sep 27, 2015
@abose abose added this to the Release 1.5 milestone Sep 29, 2015
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@sprintr @marcelgerber @abose